Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Publish PR 10244: new stream Meet in Google Admin Reports #10638

Closed
wants to merge 6 commits into from

Conversation

marcosmarxm
Copy link
Member

What

Describe what the change is solving
It helps to add screenshots if it affects the frontend.

How

Describe the solution

Recommended reading order

  1. x.java
  2. y.python

🚨 User Impact 🚨

Are there any breaking changes? What is the end result perceived by the user? If yes, please merge this PR with the 🚨🚨 emoji so changelog authors can further highlight this if needed.

Pre-merge Checklist

Expand the relevant checklist and delete the others.

New Connector

Community member or Airbyter

  • Community member? Grant edit access to maintainers (instructions)
  • Secrets in the connector's spec are annotated with airbyte_secret
  • Unit & integration tests added and passing. Community members, please provide proof of success locally e.g: screenshot or copy-paste unit, integration, and acceptance test output. To run acceptance tests for a Python connector, follow instructions in the README. For java connectors run ./gradlew :airbyte-integrations:connectors:<name>:integrationTest.
  • Code reviews completed
  • Documentation updated
    • Connector's README.md
    • Connector's bootstrap.md. See description and examples
    • docs/SUMMARY.md
    • docs/integrations/<source or destination>/<name>.md including changelog. See changelog example
    • docs/integrations/README.md
    • airbyte-integrations/builds.md
  • PR name follows PR naming conventions

Airbyter

If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.

  • Create a non-forked branch based on this PR and test the below items on it
  • Build is successful
  • Credentials added to Github CI. Instructions.
  • /test connector=connectors/<name> command is passing
  • New Connector version released on Dockerhub by running the /publish command described here
  • After the connector is published, connector added to connector index as described here
  • Seed specs have been re-generated by building the platform and committing the changes to the seed spec files, as described here
Updating a connector

Community member or Airbyter

  • Grant edit access to maintainers (instructions)
  • Secrets in the connector's spec are annotated with airbyte_secret
  • Unit & integration tests added and passing. Community members, please provide proof of success locally e.g: screenshot or copy-paste unit, integration, and acceptance test output. To run acceptance tests for a Python connector, follow instructions in the README. For java connectors run ./gradlew :airbyte-integrations:connectors:<name>:integrationTest.
  • Code reviews completed
  • Documentation updated
    • Connector's README.md
    • Connector's bootstrap.md. See description and examples
    • Changelog updated in docs/integrations/<source or destination>/<name>.md including changelog. See changelog example
  • PR name follows PR naming conventions

Airbyter

If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.

  • Create a non-forked branch based on this PR and test the below items on it
  • Build is successful
  • Credentials added to Github CI. Instructions.
  • /test connector=connectors/<name> command is passing
  • New Connector version released on Dockerhub by running the /publish command described here
  • After the new connector version is published, connector version bumped in the seed directory as described here
  • Seed specs have been re-generated by building the platform and committing the changes to the seed spec files, as described here
Connector Generator
  • Issue acceptance criteria met
  • PR name follows PR naming conventions
  • If adding a new generator, add it to the list of scaffold modules being tested
  • The generator test modules (all connectors with -scaffold in their name) have been updated with the latest scaffold by running ./gradlew :airbyte-integrations:connector-templates:generator:testScaffoldTemplates then checking in your changes
  • Documentation which references the generator is updated as needed

Tests

Unit

Put your unit tests output here.

Integration

Put your integration tests output here.

Acceptance

Put your acceptance tests output here.

zuc and others added 2 commits February 10, 2022 18:55
…udit activity events

Signed-off-by: Michele Zuccala <michele@zuccala.com>
@github-actions github-actions bot added the area/connectors Connector related issues label Feb 24, 2022
@marcosmarxm marcosmarxm temporarily deployed to more-secrets February 24, 2022 18:55 Inactive
@marcosmarxm marcosmarxm temporarily deployed to more-secrets February 24, 2022 18:55 Inactive
@marcosmarxm
Copy link
Member Author

marcosmarxm commented Feb 24, 2022

/test connector=connectors/source-google-workspace-admin-reports

🕑 connectors/source-google-workspace-admin-reports https://github.com/airbytehq/airbyte/actions/runs/1894976221
✅ connectors/source-google-workspace-admin-reports https://github.com/airbytehq/airbyte/actions/runs/1894976221
Python tests coverage:

Name                                                 Stmts   Miss  Cover
------------------------------------------------------------------------
source_acceptance_test/utils/__init__.py                 6      0   100%
source_acceptance_test/tests/__init__.py                 4      0   100%
source_acceptance_test/__init__.py                       2      0   100%
source_acceptance_test/tests/test_full_refresh.py       52      2    96%
source_acceptance_test/utils/asserts.py                 37      2    95%
source_acceptance_test/config.py                        74      6    92%
source_acceptance_test/utils/json_schema_helper.py     105     13    88%
source_acceptance_test/utils/common.py                  70     17    76%
source_acceptance_test/utils/compare.py                 62     23    63%
source_acceptance_test/tests/test_core.py              275    106    61%
source_acceptance_test/base.py                          10      4    60%
source_acceptance_test/utils/connector_runner.py       110     48    56%
source_acceptance_test/tests/test_incremental.py        69     38    45%
------------------------------------------------------------------------
TOTAL                                                  876    259    70%

Python short test summary info:

=========================== short test summary info ============================
SKIPPED [1] ../usr/local/lib/python3.7/site-packages/source_acceptance_test/plugin.py:56: Skipping TestFullRefresh.test_sequential_reads because not found in the config
=================== 21 passed, 1 skipped in 60.12s (0:01:00) ===================

@marcosmarxm marcosmarxm temporarily deployed to more-secrets February 24, 2022 19:35 Inactive
@marcosmarxm marcosmarxm temporarily deployed to more-secrets February 24, 2022 19:35 Inactive
@octavia-squidington-iii octavia-squidington-iii temporarily deployed to more-secrets February 24, 2022 19:37 Inactive
@github-actions github-actions bot added the area/documentation Improvements or additions to documentation label Feb 24, 2022
@marcosmarxm marcosmarxm temporarily deployed to more-secrets February 24, 2022 19:51 Inactive
@marcosmarxm marcosmarxm temporarily deployed to more-secrets February 24, 2022 19:51 Inactive
@marcosmarxm marcosmarxm temporarily deployed to more-secrets February 24, 2022 19:53 Inactive
@marcosmarxm marcosmarxm temporarily deployed to more-secrets February 24, 2022 19:53 Inactive
@marcosmarxm
Copy link
Member Author

marcosmarxm commented Feb 24, 2022

/publish connector=connectors/source-google-workspace-admin-reports

🕑 connectors/source-google-workspace-admin-reports https://github.com/airbytehq/airbyte/actions/runs/1895144302
✅ connectors/source-google-workspace-admin-reports https://github.com/airbytehq/airbyte/actions/runs/1895144302

@marcosmarxm marcosmarxm temporarily deployed to more-secrets February 24, 2022 20:16 Inactive
@marcosmarxm marcosmarxm temporarily deployed to more-secrets February 24, 2022 20:16 Inactive
@octavia-squidington-iii octavia-squidington-iii temporarily deployed to more-secrets February 24, 2022 20:17 Inactive
@codecov
Copy link

codecov bot commented Feb 24, 2022

Codecov Report

❗ No coverage uploaded for pull request base (master@25dc35d). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master   #10638   +/-   ##
=========================================
  Coverage          ?   84.26%           
=========================================
  Files             ?        4           
  Lines             ?      197           
  Branches          ?        0           
=========================================
  Hits              ?      166           
  Misses            ?       31           
  Partials          ?        0           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 25dc35d...3dacf20. Read the comment docs.

@marcosmarxm marcosmarxm deleted the marcos/test-pr-10244 branch March 23, 2022 16:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/connectors Connector related issues area/documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants